future-install-scripts/test/test_valid_number_of_base

#!/bin/bash

. ./fstab-helpers
. ./test/common

EXPECT_success valid_number_of_base 16 feedfacebeef
EXPECT_failure valid_number_of_base 16 feedsfacebeef
EXPECT_success valid_number_of_base 16 1234567890

EXPECT_success valid_number_of_base 10 1234567890
EXPECT_failure valid_number_of_base 10 1234.567890
EXPECT_failure valid_number_of_base 10 1234567890abcdef

EXPECT_success valid_number_of_base 18 1234567890abcdefgh
EXPECT_failure valid_number_of_base 18 1234567890abcdefghi
Add tests for some common functions 2013-12-09 01:16:58 +08:00			`#!/bin/bash`

tests: remove non-applicable ${1} handling The arg was never set. Furthermore as-is shellcheck cannot realistically evaluate the included source. Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com> 2023-03-25 02:17:10 +08:00			`. ./fstab-helpers`
Add tests for some common functions 2013-12-09 01:16:58 +08:00			`. ./test/common`

			`EXPECT_success valid_number_of_base 16 feedfacebeef`
			`EXPECT_failure valid_number_of_base 16 feedsfacebeef`
			`EXPECT_success valid_number_of_base 16 1234567890`

			`EXPECT_success valid_number_of_base 10 1234567890`
			`EXPECT_failure valid_number_of_base 10 1234.567890`
			`EXPECT_failure valid_number_of_base 10 1234567890abcdef`

fix valid_number_of_base function execution halts entirely on a invalid base, so we never actually get to our 'return 1'. I'm not sure how our expected failures ever actually worked, but it's quite plain to see that: $ a=$(( 2#3 )); echo hi Never echos "hi". Use a subshell in valid_number_of_base so that we can properly "trap" execution, and return a meaningful result. 2014-12-15 22:01:51 +08:00			`EXPECT_success valid_number_of_base 18 1234567890abcdefgh`
			`EXPECT_failure valid_number_of_base 18 1234567890abcdefghi`