diff --git a/multimedia/libdriv/liba52.xml b/multimedia/libdriv/liba52.xml index 920726854b..9436ac61f9 100644 --- a/multimedia/libdriv/liba52.xml +++ b/multimedia/libdriv/liba52.xml @@ -91,7 +91,7 @@ --mandir=/usr/share/man \ --enable-shared \ --disable-static \ - CFLAGS="${CFLAGS:--g -O3} $([ $(uname -m) = x86_64 ] && echo -fPIC)" && + CFLAGS="${CFLAGS:--g -O3} -fPIC" && make @@ -113,10 +113,15 @@ install -v -m644 -D doc/liba52.txt \ Command Explanations - CFLAGS="${CFLAGS:--g -O3} ...: This sets - CFLAGS to -g -O3 - (which is the default) but then on x86_64 adds -fPIC. This is needed to - compile liba52 on x86_64. + CFLAGS="${CFLAGS:--g -O3} -fPIC": This appends + to CFLAGS but use + (the default of this package) instead of an + empty string when CFLAGS is not set. + This is needed to compile liba52 without + runtime text relocation. Runtime text relocation is prohibited on + x86_64 so is strictly required. On 32-bit x86 + runtime text relocation is allowed but it's insecure and it may waste + physical RAM, so is still better.