linux-from-scratch/glfs
1
0
Fork 0
mirror of https://github.com/Zeckmathederg/glfs.git synced 2025-02-04 07:17:15 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

liba52: Use -fPIC even on 32-bit x86

Browse Source 
See the updated command explanation for rationale of this change.  And
it also makes the instruction simpler, so it's a win-win.
This commit is contained in:
Xi Ruoyao 2023-12-23 03:38:13 +08:00
parent b9d313c781
commit dcf0bcc2d9
No known key found for this signature in database
GPG Key ID: ACAAD20E19E710E3
1 changed files with 10 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
multimedia/libdriv/liba52.xml
View File

@ -91,7 +91,7 @@
--mandir=/usr/share/man \
--enable-shared \
--disable-static \
CFLAGS="${CFLAGS:--g -O3} $([ $(uname -m) = x86_64 ] && echo -fPIC)" &&
CFLAGS="${CFLAGS:--g -O3} -fPIC" &&
make</userinput></screen>
<para>
@ -113,10 +113,15 @@ install -v -m644 -D doc/liba52.txt \
<title>Command Explanations</title>
<para>
<parameter>CFLAGS="${CFLAGS:--g -O3} ...</parameter>: This sets
CFLAGS to -g -O3
(which is the default) but then on x86_64 adds -fPIC. This is needed to
compile <application>liba52</application> on x86_64.
<parameter>CFLAGS="${CFLAGS:--g -O3} -fPIC"</parameter>: This appends
<option>-fPIC</option> to <envar>CFLAGS</envar> but use
<option>-g -O3</option> (the default of this package) instead of an
empty string when <envar>CFLAGS</envar> is not set.
This is needed to compile <application>liba52</application> without
runtime text relocation. Runtime text relocation is prohibited on
x86_64 so <option>-fPIC</option> is strictly required. On 32-bit x86
runtime text relocation is allowed but it's insecure and it may waste
physical RAM, so <option>-fPIC</option> is still better.
</para>
<xi:include xmlns:xi="http://www.w3.org/2001/XInclude"